Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(archive): refactor archive drivers for store v3 #2729

Closed
wants to merge 5 commits into from

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented May 24, 2024

Description

I refactored the archive drivers to better support Store v3. I made changes that may require a migration.

After this is merged, archive/store performance reviewing can start.

The legacy drivers can be enabled via a config flag (default off).

Addresses issues like #2637

Copy link

This PR may contain changes to database schema of one of the drivers.

If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues.

Please make sure the label release-notes is added to make sure upgrade instructions properly highlight this change.

@SionoiS SionoiS force-pushed the chore--refactor-archive-drivers branch from c8585e9 to 1ec2ab6 Compare May 27, 2024 15:57
Copy link

github-actions bot commented May 27, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2729-rln-v1

Built from 643dfe2

Copy link

github-actions bot commented May 27, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2729-rln-v2

Built from 643dfe2

@SionoiS
Copy link
Contributor Author

SionoiS commented May 28, 2024

I'll split this PR in 3 for each driver

@SionoiS SionoiS closed this May 28, 2024
@SionoiS SionoiS deleted the chore--refactor-archive-drivers branch September 25, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant