chore(archive): queue driver refactor #2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SionoiS
requested review from
darshankabariya,
gabrielmer,
NagyZoltanPeter and
Ivansete-status
Ivansete-status
approved these changes
May 31, 2024
|
Well, as usual, all should pass but the |
Yes this only support v3.
No, we discussed this, it cannot otherwise the PR would be HUGE. All PRs in review have to be merged to the feature branch before I can handle failing tests. |
Okay perfect, then feel free to merge it :) |
SionoiS
merged commit ac74ebe
into
chore--archive-drivers-refactor
7 of 18 checks passed
SionoiS
added a commit
that referenced
this pull request
Jun 6, 2024
SionoiS
added a commit
that referenced
this pull request
Jun 7, 2024
SionoiS
added a commit
that referenced
this pull request
Jun 12, 2024
SionoiS
added a commit
that referenced
this pull request
Jul 2, 2024
SionoiS
added a commit
that referenced
this pull request
Jul 4, 2024
SionoiS
added a commit
that referenced
this pull request
Jul 8, 2024
SionoiS
added a commit
that referenced
this pull request
Jul 9, 2024
Ivansete-status
pushed a commit
that referenced
this pull request
Jul 12, 2024
Ivansete-status
added a commit
that referenced
this pull request
Jul 12, 2024
* queue driver refactor (#2753) * chore(archive): archive refactor (#2752) * chore(archive): sqlite driver refactor (#2754) * chore(archive): postgres driver refactor (#2755) * chore(archive): renaming & copies (#2751) * posgres legacy: stop using the storedAt field * migration script 6: we still need the id column The id column is needed because it contains the message digest which is used in store v2, and we need to keep support to store v2 for a while * legacy archive: set target migration version to 6 * waku_node: try to use wakuLegacyArchive if wakuArchive is nil * node_factory, waku_node: mount legacy and future store simultaneously We want the nwaku node to simultaneously support store-v2 requests and store-v3 requests. Only the legacy archive is in charge of archiving messages, and the archived information is suitable to fulfill both store-v2 and store-v3 needs. * postgres_driver: adding temporary code until store-v2 is removed --------- Co-authored-by: Ivan FB <128452529+Ivansete-status@users.noreply.github.com> Co-authored-by: gabrielmer <101006718+gabrielmer@users.noreply.github.com> Co-authored-by: Ivan Folgueira Bande <ivansete@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.