chore(rlnv2): contract interface changes #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
force-pushed
the
rlnv2-contract-interface-changes
branch
from
37073d8 to
c67a659
Compare
|
You can find the image built from this PR at Built from 4b22da1 |
|
You can find the image built from this PR at Built from 4b22da1 |
rymnc
force-pushed
the
rlnv2-contract-interface-changes
branch
3 times, most recently
from
a9f0a9b to
6298267
Compare
Closed
25 tasks
4 tasks
|
cc: reviewers, please note the base branch is #2759 |
Ivansete-status
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
LGTM although I don't understand it 100%
@rymnc - will that contract change require a membership migration from the old contract to the new one?
| let leaf = rateCommitment.toLeaf().get() | ||
| await g.registerBatch(@[leaf]) | ||
| except CatchableError: | ||
| raise newException(ValueError, getCurrentExceptionMsg()) |
There was a problem hiding this comment.
Suggested change
| raise newException(ValueError, getCurrentExceptionMsg()) | |
| raise newException(ValueError, "exception reraised in atomicBatch: " & getCurrentExceptionMsg()) |
There was a problem hiding this comment.
as @alrevuelta mentioned in thread, we will ask operators to re-register memberships to the new contract
gabrielmer
approved these changes
Jun 5, 2024
|
Thanks for this @rymnc! |
stubbsta
approved these changes
Jun 5, 2024
rymnc
force-pushed
the
rlnv2-contract-interface-changes
branch
from
153e0e0 to
cec881b
Compare
rymnc
added a commit
that referenced
this pull request
Jun 20, 2024
* chore(rlnv2): contract interface changes * fix: tests * fix: remove stuint[32]
4 tasks
Ivansete-status
pushed a commit
that referenced
this pull request
Jun 20, 2024
Ivansete-status
pushed a commit
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the contract interface changes as shown in https://github.com/waku-org/waku-rlnv2-contract
All tests have been altered for the same
Changes