Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't decode plus sign for legacy store #2775

Closed
wants to merge 1 commit into from
Closed

fix: don't decode plus sign for legacy store #2775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions waku/waku_api/rest/legacy_store/types.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ proc parseMsgDigest*(
if not input.isSome() or input.get() == "":
return ok(none(waku_store_common.MessageDigest))

let decodedUrl = decodeUrl(input.get())
let decodedUrl = decodeUrl(input.get(), false)
let base64Decoded = base64.decode(Base64String(decodedUrl))
var messageDigest = waku_store_common.MessageDigest()

Expand All @@ -87,7 +87,7 @@ proc parseMsgDigest*(
# and this result is URL-encoded.
proc toRestStringMessageDigest*(self: waku_store_common.MessageDigest): string =
let base64Encoded = base64.encode(self.data)
encodeUrl($base64Encoded)
encodeUrl($base64Encoded, false)

proc toWakuMessage*(message: StoreWakuMessage): WakuMessage =
WakuMessage(
Expand Down
Loading