Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase on chain group manager starting balance #2795

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

gabrielmer
Copy link
Contributor

@gabrielmer gabrielmer commented Jun 10, 2024

Description

We started seeing in the CI the following error repeatedly in tests/waku_rln_relay/test_rln_group_manager_onchain.nim

Unhandled error: {"code":-32003,"message":"Insufficient funds for gas * price + value"} [ValueError]

Increasing the initial eth balance for the tests to avoid this error

Changes

  • increased initial balance for on chain group manager tests

Copy link

github-actions bot commented Jun 10, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2795-rln-v2

Built from c6af45b

Copy link

github-actions bot commented Jun 10, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2795-rln-v1

Built from c6af45b

@gabrielmer gabrielmer changed the title chore: debug CI insufficient funds errors [DEBUG] fix: increase on chain group manage starting balance Jun 10, 2024
@gabrielmer gabrielmer marked this pull request as ready for review June 10, 2024 11:24
@rymnc
Copy link
Contributor

rymnc commented Jun 10, 2024 via email

@Ivansete-status
Copy link
Collaborator

maybe want to increase the amount here by 10 too: https://github.com/waku-org/nwaku/blob/master/tests%2Fwaku_rln_relay%2Ftest_rln_group_manager_onchain.nim#L118

On Mon, Jun 10, 2024, 16:55 gabrielmer @.> wrote: @gabrielmer https://github.com/gabrielmer requested your review on: #2795 <#2795> fix: increase on chain group manage starting balance. — Reply to this email directly, view it on GitHub <#2795 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKNQ6FHMNMDQ5AUC5UH6VJLZGWEJPAVCNFSM6AAAAABJCBBGC6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGA4TSOBUGA3TANQ . You are receiving this because your review was requested.Message ID: @.>

By 10 or by 1000 so that it never fails again :P

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 💯
I'd apply @rymnc 's suggestion as well :)
Cheers

@gabrielmer
Copy link
Contributor Author

maybe want to increase the amount here by 10 too: https://github.com/waku-org/nwaku/blob/master/tests%2Fwaku_rln_relay%2Ftest_rln_group_manager_onchain.nim#L118

Oh niiiice, just applied it :)) Thanks so much!

By 10 or by 1000 so that it never fails again :P

Loool, went for the middle ground and increased it by 100 😄

Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if checks pass

@gabrielmer gabrielmer changed the title fix: increase on chain group manage starting balance fix: increase on chain group manager starting balance Jun 10, 2024
@gabrielmer gabrielmer merged commit e72bb7e into master Jun 10, 2024
16 of 17 checks passed
@gabrielmer gabrielmer deleted the debug-failed-ci-error-insufficient-funds branch June 10, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants