-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase on chain group manager starting balance #2795
Conversation
You can find the image built from this PR at
Built from c6af45b |
You can find the image built from this PR at
Built from c6af45b |
This reverts commit 0ab337d.
maybe want to increase the amount here by 10 too:
https://github.com/waku-org/nwaku/blob/master/tests%2Fwaku_rln_relay%2Ftest_rln_group_manager_onchain.nim#L118
…On Mon, Jun 10, 2024, 16:55 gabrielmer ***@***.***> wrote:
@gabrielmer <https://github.com/gabrielmer> requested your review on:
#2795 <#2795> fix: increase on
chain group manage starting balance.
—
Reply to this email directly, view it on GitHub
<#2795 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKNQ6FHMNMDQ5AUC5UH6VJLZGWEJPAVCNFSM6AAAAABJCBBGC6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGA4TSOBUGA3TANQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
By 10 or by 1000 so that it never fails again :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks! 💯
I'd apply @rymnc 's suggestion as well :)
Cheers
Oh niiiice, just applied it :)) Thanks so much!
Loool, went for the middle ground and increased it by 100 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if checks pass
Description
We started seeing in the CI the following error repeatedly in
tests/waku_rln_relay/test_rln_group_manager_onchain.nim
Increasing the initial eth balance for the tests to avoid this error
Changes