-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding discv5 logs #2811
Conversation
You can find the image built from this PR at
Built from 3f8c1b8 |
You can find the image built from this PR at
Built from 3f8c1b8 |
db93e1c
to
1ef77ec
Compare
You can find the image built from this PR at
Built from a4177c1 |
1ef77ec
to
68cb89c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for it! 💯
I just added a minor nitpick comment
Very insightful PR and beautiful how you use the zip
proc 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Description
Adding logs when discv5 finds new peers and when the node connects to new peers. These logs will be under the compilation flag
DEBUG_DISCV5
so it is used for DST simulations.It can be tested in the following image:
Example logs
CC @AlbertoSoutullo
Issue
related to #2810
closes #2841