Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding discv5 logs #2811

Merged
merged 16 commits into from
Jun 26, 2024
Merged

chore: adding discv5 logs #2811

merged 16 commits into from
Jun 26, 2024

Conversation

gabrielmer
Copy link
Contributor

@gabrielmer gabrielmer commented Jun 14, 2024

Description

Adding logs when discv5 finds new peers and when the node connects to new peers. These logs will be under the compilation flag DEBUG_DISCV5 so it is used for DST simulations.

It can be tested in the following image:

harbor.status.im/wakuorg/nwaku:discv5-debug-logs

Example logs

nwaku-1  | NTC 2024-06-25 12:07:43.869+00:00 Received discv5 node                       topics="waku discv5" tid=1 file=waku_discv5.nim:197 addrs=/ip4/195.201.172.178/tcp/30304/p2p/16Uiu2HAmKQAGsUAoUVMt6j7FLRWmou2z3a1WE6CGUiG1YKxWtq2u enr=enr:-LW4QK7dmsv43R2qQknllshhYx9IDEu1cD1t6Ao601ppx8oWYr_joTyfKXjoxQAST1iuGTXfs0ETtJ1fCrZef-GYHrsBgmlkgnY0gmlwhMPJrLKKbXVsdGlhZGRyc4CCcnOTAAEIAAAAAQACAAMABAAFAAYAB4lzZWNwMjU2azGhA2Q1UTaE09UZWli2y5AZFwE-3RGoGGvwrQ_9B5YAy_VWg3RjcIJ2YIN1ZHCCIy2Fd2FrdTIP capabilities="@[Relay, Store, Filter, Lightpush]" shards="(clusterId: 1, shardIds: @[0, 1, 2, 3, 4, 5, 6, 7])"
nwaku-1  | NTC 2024-06-25 12:08:53.816+00:00 established connections with found peers   topics="waku node peer_manager" tid=1 file=peer_manager.nim:670 peerIds="@[16Uiu2HAmB7Ur9HQqo3cWDPovRQjo57fxWWDaQx27WxSzDGhN4JKg, 16Uiu2HAmNTpGnyZ8W1BK2sXEmgSCNWiyDKgRU3NBR2DXST2HzxRU]" origin="@[Discv5, Discv5]"

CC @AlbertoSoutullo

Issue

related to #2810
closes #2841

Copy link

github-actions bot commented Jun 14, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2811-rln-v1

Built from 3f8c1b8

Copy link

github-actions bot commented Jun 14, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2811-rln-v2

Built from 3f8c1b8

@gabrielmer gabrielmer force-pushed the debug-discv5-issue branch from db93e1c to 1ef77ec Compare June 21, 2024 08:45
Copy link

github-actions bot commented Jun 21, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2811

Built from a4177c1

@gabrielmer gabrielmer force-pushed the debug-discv5-issue branch from 1ef77ec to 68cb89c Compare June 24, 2024 15:54
@gabrielmer gabrielmer changed the title chore: debug discv5 [DEBUG] chore: adding discv5 logs Jun 25, 2024
@gabrielmer gabrielmer marked this pull request as ready for review June 25, 2024 12:43
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯
I just added a minor nitpick comment
Very insightful PR and beautiful how you use the zip proc 🥳

waku/node/peer_manager/peer_manager.nim Outdated Show resolved Hide resolved
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@gabrielmer gabrielmer merged commit 974b8a3 into master Jun 26, 2024
8 of 10 checks passed
@gabrielmer gabrielmer deleted the debug-discv5-issue branch June 26, 2024 12:25
gabrielmer added a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: add logs when discovering and connecting to discv5 peers
3 participants