fix: adding peer exchange peers to the peerStore #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from b4d5906 |
|
You can find the image built from this PR at Built from b4d5906 |
|
I tried to also take care of nwaku/waku/factory/node_factory.nim Line 133 in e41aa57 But noticed that in the handler we don't receive the exchanged peers ENRs so we can't filter by the cluster/shards. Maybe I'm missing something. In any case, I think that the Peer Manager itself should be in charge of the filtering peers by shards so we don't duplicate the logic. This should be taken care of when we activating sharded peer management. |
gabrielmer
requested review from
Ivansete-status,
richard-ramos,
chaitanyaprem,
darshankabariya and
NagyZoltanPeter
Ivansete-status
approved these changes
Jun 19, 2024
NagyZoltanPeter
approved these changes
Jun 20, 2024
gabrielmer
deleted the
adding-peer-exchange-peers-instead-of-connecting-directly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As soon we receive peers in Peer Exchange, we currently try to connect to all of them directly in a very aggressive way.
This does not take into account our connection targets and limits. Therefore, we should first add the peers to the Peer Store, and the connectivity loop will be in charge to choose and connect to the amount of peers necessary to reach its targets.
Changes
Issue
We saw this case happen and potentially cause issues in #2780