-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add last online timestamp to archive and drivers #2916
Conversation
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
You can find the image built from this PR at
Built from 1c470e7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need a migration just to add a new table?
Thanks for that @SionoiS ! Nevertheless, I'm curious about the underlying deliverable/milestone :) |
It's part of Store sync waku-org/pm#131 |
Cool thanks! In that case, I think is better to have a separate sqlite database where we store that info. Similar to the |
Description
This PR adds a way to save a timestamp periodically so that we can know when the node was last online.
This feature will be used for a future store resume functionality.
Changes