Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: misc. updates for discovery network analysis #2930

Merged
merged 3 commits into from
Aug 7, 2024
Merged

feat: misc. updates for discovery network analysis #2930

merged 3 commits into from
Aug 7, 2024

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Jul 24, 2024 •
edited
Loading

Description

I added more metrics to understand the discovery network better and a way to start without RLN.

I also created a new dashboard focused on discovery and changed the avg latency algo. to a smooth moving average.

Changes

  • new dashboard
  • network monitor start without rln
  • network monitor cluster id metrics
  • replace the avg latency algo.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2930

Built from c5db12a

@SionoiS SionoiS marked this pull request as ready for review July 25, 2024 15:02
@SionoiS SionoiS requested review from vpavlin and a team July 25, 2024 15:02
gabrielmer
gabrielmer reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niice, thank you! Looks great 🤩

Could you please add a screenshot of the new dashboard?

The linting check in the CI is failing, please have a look and if you think it can be an issue of the check itself lmk and I'll take care of it

@SionoiS
Copy link
Contributor Author

SionoiS commented Jul 26, 2024

Looks like this!
Screenshot from 2024-07-26 15-48-14

@SionoiS SionoiS mentioned this pull request Jul 26, 2024
Merged
3 tasks
@gabrielmer gabrielmer self-requested a review July 29, 2024 08:11
gabrielmer
gabrielmer approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazingg! 😍

Thanks so much!

@SionoiS SionoiS requested a review from a team August 7, 2024 13:36
jm-clius
jm-clius approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty cool.

@SionoiS SionoiS merged commit 4340eb7 into master Aug 7, 2024
10 of 13 checks passed
@SionoiS SionoiS deleted the feat--networkmonitor-disco branch August 7, 2024 18:58
@NagyZoltanPeter NagyZoltanPeter mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius jm-clius approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

@vpavlin vpavlin Awaiting requested review from vpavlin

Assignees

@SionoiS SionoiS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SionoiS @jm-clius @gabrielmer