chore: enhance libwaku store protocol and more #3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 21bf68e |
richard-ramos
approved these changes
Dec 20, 2024
Comment on lines
+31
to
+39
| if jsonContent.contains("message_hashes"): | ||
| for hashJsonObj in jsonContent["message_hashes"].getElems(): | ||
| var hash: WakuMessageHash | ||
| var count: int = 0 | ||
| for byteValue in hashJsonObj.getElems(): | ||
| hash[count] = byteValue.getInt().byte | ||
| count.inc() | ||
|
|
||
| hash | ||
| hash |
There was a problem hiding this comment.
Same question as waku-org/waku-rust-bindings#105 (comment)
There was a problem hiding this comment.
Same question as waku-org/waku-rust-bindings#105 (comment)
Yes good point! The reason for that is to make it work in the same way as relay:
This reverts commit 243d466.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR was initially meant for enhancing how store protocol worked but it ended up collecting other enhancements
Changes
%not needed inlibrary/events/json_message_event.nimbecause we want the messageHash be returned as a sequence, .e.g[121, 9, ..., 98].libwaku.nim: avoid passingWakuRelayHandler(onReceivedMessage(ctx)),inwaku_relay_publishbecause it doesn't make sense.store_request.nim.waku_thread.nim: addition of reqReceivedSignal to make sure every request is received (not processed) by The Waku Thread before the next request is sent to The Waku Thread.How to test
Can be tested by using the
toy-chatapp. See waku-org/waku-rust-bindings#105Impacted Issue