Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve node metrics #831

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Improve node metrics #831

merged 2 commits into from
Jan 26, 2022

Conversation

jm-clius
Copy link
Contributor

@jm-clius jm-clius commented Jan 25, 2022

Minor PR towards #828

It adds:

  1. A dimension to the message counter to keep track of the number of contentTopics in the network. This should enable us to build Prometheus queries to view i.a. the number of applications using the network.
  2. A metric to track the number and type of connections initiated by the nwaku node. This will allow us to monitor number of connections initiated due to static configuration, dns discovery, discv5, API calls, and more.
  3. Some error handling for failed connections initiated by this node.

For (2) it was necessary to clean up the connect and dial API in wakunode2 (somewhat).

There is some parallel work ongoing to update the bundled Grafana dashboard accordingly.

@status-im-auto
Copy link
Collaborator

status-im-auto commented Jan 25, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8a576ed #1 2022-01-25 16:16:31 ~14 min macos 📦bin
✔️ 8a576ed #1 2022-01-25 16:17:33 ~15 min linux 📦bin
✔️ 8a576ed #1 2022-01-25 16:34:46 ~32 min windows 📦exe
✔️ ae3e1cc #2 2022-01-26 09:20:33 ~11 min linux 📦bin
✔️ ae3e1cc #2 2022-01-26 09:21:03 ~12 min macos 📦bin
✔️ ae3e1cc #2 2022-01-26 09:34:40 ~25 min windows 📦exe

Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jm-clius jm-clius merged commit 4421b8d into master Jan 26, 2022
@jm-clius jm-clius deleted the metrics-improve branch January 26, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants