Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default fleet metrics dashboard #844

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Update default fleet metrics dashboard #844

merged 1 commit into from
Feb 8, 2022

Conversation

jm-clius
Copy link
Contributor

@jm-clius jm-clius commented Feb 7, 2022

This PR contains many tweaks, additions and updates to the default "fleet" metrics dashboard for nwaku.

It forms a part of #828, and most changes are aimed at making the dashboard more operator-focused. Some changes are aimed at improved memory monitoring.

Highlights

  1. Message counter is now displayed as a rate per minute, rather than just an ever-increasing total:

image

  1. Panels showing the total number of content topics and the message rate for the top content topics. Note this metric is not available on prod yet.

image

  1. Detailed memory and heap stats

image

And many more! Live version of the dashboard can be found here

@status-im-auto
Copy link
Collaborator

status-im-auto commented Feb 7, 2022 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ c94e276 #1 2022-02-07 17:42:28 ~5 min linux 📄log
⁉️ c94e276 #1 2022-02-07 17:44:10 ~7 min macos 📄log
⁉️ c94e276 #1 2022-02-07 17:56:41 ~19 min windows 📄log

@jm-clius jm-clius merged commit 0cbab6c into master Feb 8, 2022
@jm-clius jm-clius deleted the feat/dashboard-improve branch February 8, 2022 11:22
@staheri14 staheri14 mentioned this pull request Feb 9, 2022
Merged
3 tasks
s1fr0 pushed a commit that referenced this pull request Feb 9, 2022
@jm-clius @s1fr0
Update default fleet metrics dashboard (#844)
542205a 
Signed-off-by: G <28568419+s1fr0@users.noreply.github.com>
s1fr0 pushed a commit that referenced this pull request Feb 9, 2022
@jm-clius @s1fr0
Update default fleet metrics dashboard (#844)
8d9350c 
Signed-off-by: G <28568419+s1fr0@users.noreply.github.com>
s1fr0 pushed a commit that referenced this pull request Feb 9, 2022
@jm-clius @s1fr0
Update default fleet metrics dashboard (#844)
a1a7fcb 
Signed-off-by: G <28568419+s1fr0@users.noreply.github.com>
Signed-off-by: s1fr0 <28568419+s1fr0@users.noreply.github.com>
s1fr0 pushed a commit that referenced this pull request Feb 9, 2022
@jm-clius @s1fr0
Update default fleet metrics dashboard (#844)
64fbfc6 
Signed-off-by: G <28568419+s1fr0@users.noreply.github.com>
Signed-off-by: s1fr0 <28568419+s1fr0@users.noreply.github.com>
s1fr0 pushed a commit that referenced this pull request Feb 9, 2022
@jm-clius @s1fr0
Update default fleet metrics dashboard (#844)
a741812 
Signed-off-by: G <28568419+s1fr0@users.noreply.github.com>
Signed-off-by: s1fr0 <28568419+s1fr0@users.noreply.github.com>
s1fr0 pushed a commit that referenced this pull request Feb 9, 2022
@jm-clius @s1fr0
Update default fleet metrics dashboard (#844)
7cd88d4 
Signed-off-by: G <28568419+s1fr0@users.noreply.github.com>
Signed-off-by: s1fr0 <28568419+s1fr0@users.noreply.github.com>
s1fr0 pushed a commit that referenced this pull request Feb 9, 2022
@jm-clius @s1fr0
Update default fleet metrics dashboard (#844)
b9bc2c1 
Signed-off-by: G <28568419+s1fr0@users.noreply.github.com>
Signed-off-by: s1fr0 <28568419+s1fr0@users.noreply.github.com>
s1fr0 pushed a commit that referenced this pull request Feb 9, 2022
@jm-clius @s1fr0
Update default fleet metrics dashboard (#844)
a463f35
s1fr0 added a commit that referenced this pull request Feb 17, 2022
@s1fr0 @staheri14 @jm-clius
Refactoring timestamps (#842)
21cac6d 
* Refactor timestamps type from float64 to int64 (milliseconds resolution)

* Revert epochs to float64

* Update 00002_addSenderTimeStamp.up.sql

* Update quicksim2.nim

* Add files via upload

* Delete 00003_convertTimestampsToInts.up.sql

* Add files via upload

* Rename 00003_convertTimestampsToInts.up.sql to 00003_addTimestampsToInts.up.sql

* Delete 00003_addTimestampsToInts.up.sql

* Rln-relay integration into chat2 (#835)

* adds ProofMetadata

* adds EPOCH_INTERVAL

* adds messageLog field

* adds updateLog, toEpoch, fromEpoch, getEpoch, compareTo

* adds unit test for toEpoch and fromEpoch

* adds unit test for Epoch comparison

* adds result codes for updateLog

* adds unit test for update log

* renames epoch related consts

* modifies updateLog with new return type and new logic of spam detection

* adds unit text for the modified updateLog

* changes max epoch gap type size

* splits updateLog into two procs isSpam and updateLog

* updates unittests

* fixes a bug, returns false when the message is not spam

* renames messageLog to nullifierLog

* renames isSpam to hasDuplicate

* updates the rln validator, adds comments

* adds appendRLNProof proc plus some code beatification

* unit test for validate message

* adds unhappy test to validateMessage unit test

* renames EPOCH_UNIT_SECONDS

* renames MAX_CLOCK_GAP_SECONDS

* WIP: integration test

* fixes compile errors

* sets a real epoch value

* updates on old unittests

* adds comments to the rln relay tests

* adds more comments

* makes rln import conditional

* adds todos

* adds more todos

* adds rln-relay mount process into chat2

* further todos

* logs contentTopic

* introduces rln relay configs

* changes default pubsub topic

* adds contentTopic config

* imports rln relay dependencies

* consolidates imports

* removes module identifier from ContentTopic

* adds contentTopic field

* adds contentTopic argument to mountRlnRelay calls

* appends rln proof to chat2 messages

* changes the default chat2 contentTopic

* adds missing content topic fields

* fixes a bug

* adds a new logic about empty content topics

* appends proof only when rln flag is active

* removes unnecessary todos

* fixes an indentation issue

* adds log messages

* verifies the proof against the concatenation of msg payload and content topic

* a bug fix

* removes duplicate epoch time calculation

* updates log level to trace

* updates default rln-relay content topic

* adds support for empty content topics

* updates changelog

* changelog updates

* removes a commented code block

* updates addRLNRelayValidator string doc

* Squashed commit of the following:

commit bc36c99
Merge: dc2b294 5a77d6e
Author: G <28568419+s1fr0@users.noreply.github.com>
Date:   Sat Feb 5 01:10:06 2022 +0100

    Merge branch 'master' into int64-timestamps-ns

commit dc2b294
Author: s1fr0 <28568419+s1fr0@users.noreply.github.com>
Date:   Sat Feb 5 00:24:45 2022 +0100

    Fix

commit f97b95a
Author: s1fr0 <28568419+s1fr0@users.noreply.github.com>
Date:   Sat Feb 5 00:13:18 2022 +0100

    Missing import

commit 060c4f8
Author: s1fr0 <28568419+s1fr0@users.noreply.github.com>
Date:   Sat Feb 5 00:10:36 2022 +0100

    Fixed typo

commit 08ca99b
Author: s1fr0 <28568419+s1fr0@users.noreply.github.com>
Date:   Fri Feb 4 23:59:20 2022 +0100

    Time util file

commit 2b5c360
Author: s1fr0 <28568419+s1fr0@users.noreply.github.com>
Date:   Fri Feb 4 23:33:20 2022 +0100

    Moved time utility functions to utils/time

commit fdaf121
Author: s1fr0 <28568419+s1fr0@users.noreply.github.com>
Date:   Fri Feb 4 23:10:25 2022 +0100

    Fix comment

commit c7e06ab
Author: s1fr0 <28568419+s1fr0@users.noreply.github.com>
Date:   Fri Feb 4 23:04:13 2022 +0100

    Restore previous migration script

commit 80282db
Author: s1fr0 <28568419+s1fr0@users.noreply.github.com>
Date:   Fri Feb 4 22:54:15 2022 +0100

    Typo

commit b9d67f8
Author: s1fr0 <28568419+s1fr0@users.noreply.github.com>
Date:   Fri Feb 4 22:49:29 2022 +0100

    Added utilities to get int64 nanosecond, microsecond, millisecond time resolution from float

commit 0130d49
Author: s1fr0 <28568419+s1fr0@users.noreply.github.com>
Date:   Fri Feb 4 22:36:35 2022 +0100

    Switched to nanoseconds support.

* Update CHANGELOG.md

* Create 00003_convertTimestampsToInt64.up.sql

Migration script

* Moved migration script to right location

* Update waku_rln_relay_utils.nim

* Update waku_rln_relay_utils.nim

* Addressed reviewers' comments

* Update default fleet metrics dashboard (#844)

* Fix

* No need for float

* Aligning master to changes in PR

* Further fixes

Co-authored-by: Sanaz Taheri Boshrooyeh <35961250+staheri14@users.noreply.github.com>
Co-authored-by: Hanno Cornelius <68783915+jm-clius@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarth oskarth oskarth approved these changes

@kaiserd kaiserd Awaiting requested review from kaiserd

@s1fr0 s1fr0 Awaiting requested review from s1fr0

@staheri14 staheri14 Awaiting requested review from staheri14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jm-clius @status-im-auto @oskarth