-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved PB Timestamp index to 10 #861
Conversation
Thanks! This will buy some time for other clients to implement the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Jenkins Builds
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, what triggered this change? what was the issue with index 4?
Update: found the answer in
Thanks! This will buy some time for other clients to implement the new
WakuMessage
proto without breaking.
Are we going to bring it back to index 4 once the timestamp type and resolution are updated by other clients?
This is a fix to maintain retro-compatibility with
timestamp
protobuffer fields.Timestamps now have
Timestamp
type (currently an alias forint64
) and nanoseconds resolution. Their new protobuffer index is10
.Previous versions had timestamps as
float
with subseconds contained in the fractional part and protobuffer index4
.This PR is related to vacp2p/rfc#491, #842 and vacp2p/rfc#483.