Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #140 #144

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Fix #140 #144

merged 2 commits into from
Feb 5, 2024

Conversation

* Add test cases for #140.

* Fix #140.
@khatchad khatchad added the bug Something isn't working label Feb 5, 2024
@khatchad khatchad self-assigned this Feb 5, 2024
@khatchad khatchad requested a review from msridhar February 5, 2024 17:38
@khatchad khatchad enabled auto-merge (squash) February 5, 2024 17:40
@khatchad khatchad changed the title Fix #140 (#82) Fix #140 Feb 5, 2024
@khatchad khatchad disabled auto-merge February 5, 2024 19:26
@khatchad khatchad enabled auto-merge (squash) February 5, 2024 19:26
Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@@ -88,6 +91,12 @@ public class PythonTensorAnalysisEngine extends PythonAnalysisEngine<TensorTypeA
TypeName.string2TypeName("Ltensorflow/functions/set_shape")),
AstMethodReference.fnSelector);

private static final MethodReference enumerate =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use all caps for a constant?

@khatchad khatchad requested a review from msridhar February 5, 2024 22:21
@khatchad khatchad merged commit a934e0e into master Feb 5, 2024
1 check passed
@khatchad khatchad deleted the contrib_fix_140 branch February 15, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The first element of the tuple returned by enumerate when given in a dataset is erroneously marked as a tensor
2 participants