Several updates #161
Merged
Several updates #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent infinite recursion, only the "top-level" method established the "seen" set.
I originally wrote this as a proof-of-concept and testing, but it's not a legal case because the `Dataset` ctor isn't publicly visible. In other words, `Dataset` isn't a ctor that returns in `Dataset` in "real life." Doing this initially just made the implementation a bit easier to visualize.
It shouldn't just pass-through it's argument. Otherwise, the PA doesn't look right.
* Intraprocedural case for dataset iterators. * More tests. * Handle the intraprocedural case.
This reverts commit 53aa471. It's failing test cases in our client but seems not to do any harm here.
…_from_directory()`.
khatchad
added
enhancement
|
Oops. Some of this is covered in #160. |
Yup. I resolved the conflicts introduced from #167.
It shouldn't matter. If you merge #160 first, then a proper subset of this PR should disappear. If, on the other hand, you merge this PR first, then #160 should become empty. |
msridhar
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iter()andnext()built-ins.tf.keras.preprocessing.image.ImageDataGenerator.flow_from_directory().