Bump Error Prone to 2.35.1 and enable javac -parameters flag
#1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 813 files ±0 813 suites ±0 4h 12m 11s ⏱️ + 22m 45s Results for commit 1c11ec6. ± Comparison against base commit 6010348. This pull request removes 116 and adds 116 tests. Note that renamed tests count towards both. |
liblit
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-parametersflag is required for certain checks like ArgumentSelectionDefectChecker. We enable a couple of those checks; they don't turn up any issues at the moment. In a follow up I'd like to enable BooleanParameter and auto-fix extant issues.