Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed changes #1

Merged
merged 7 commits into from
Mar 15, 2024
Merged

Proposed changes #1

merged 7 commits into from
Mar 15, 2024

Conversation

dg0yt
Copy link

@dg0yt dg0yt commented Mar 15, 2024

You may pick parts as you like. I didn't test more than vcpkg install for x64-linux and x64-linux-dynamic.

  • debug/include is never written.
  • vcpkg wants to have all tools to be in tools, even on linux. I don't like it, but it is a fact.
  • The CMake config may just assumed that everything is installed correctly. Otherwise it is a port bug, not a "package not found".
  • The cmake config file uses the package name pattern for case-insensitive matches. CMake will set <requested-name>_FOUND. I dropped explicit setting of directx-dxc_FOUND.
  • Just generic target properties.
  • Directly set DIRECTX_DXC_TOOL as a cache variable. Doesn't hurt, and user might override it to a host path for cross builds.
  • Unchanged: The variable name pattern of DIRECTX_DXC_TOOL neither matches the former explicit directx-dxc_FOUND nor the general <requested-name>_FOUND (unless the user asked for find_package(DIRECTX_DXC)).
  • On linux, the libs use libz.so.1. With port zlib installed, this will resolve to that port's binary instead of a system binary. To avoid subtle effects from installation order, I suggest to make zlib an explicit dependency at least for dynamic triplets.

Fix for Release alt configurations
@walbourn walbourn merged commit 6c3da1f into walbourn:directxdxcfix Mar 15, 2024
1 check failed
@dg0yt dg0yt deleted the directx-dxc branch March 22, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants