[fix] pageview api struct refactor #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizheming
commented
Feb 17, 2024
| getArticleCounter({ | ||
| serverURL, | ||
| lang, | ||
| paths, | ||
| type: ['time'], | ||
| signal, | ||
| }) | ||
| // TODO: Improve this API |
There was a problem hiding this comment.
由于 @waline/api 已经采用新的 API 结构了，所以旧版本的兼容可以移除掉。
Since @waline/api has adopted the new API structure, the compatibility of the old version can be removed.
lizheming
commented
Feb 17, 2024
| export type GetArticleCounterResponseItem = Record<string, number> & | ||
| CounterFields; | ||
|
|
||
| export type GetArticleCounterResponse = GetArticleCounterResponseItem[]; |
There was a problem hiding this comment.
优化 GetArticleCounterResponse 类型，移除掉非数组返回的兼容类型，统一返回类型的数据结构，增加已知类型的指定。
Optimize the GetArticleCounterResponse type, remove the compatible types returned by non-arrays, unify the data structure of the return type, and add the specification of known types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2207 when pr merged