Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations are not updated or deleted #1026

Closed
di72nn opened this issue Jul 27, 2020 · 0 comments · Fixed by #1028
Closed

Annotations are not updated or deleted #1026

di72nn opened this issue Jul 27, 2020 · 0 comments · Fixed by #1028
Labels

Comments

@di72nn
Copy link
Member

di72nn commented Jul 27, 2020

Issue details

Annotations are not properly updated or deleted.
Newly created annotations (i.e. without refreshing webview) cannot be modified at all.

2020-07-27 12:03:30.149 29592-29592/fr.gaulupeau.apps.InThePoche.debug D/WebView.onCM: Uncaught TypeError: annotation must have an id for update() @ 23: file:///android_asset/annotator.min.js
2020-07-27 12:03:43.056 29592-29592/fr.gaulupeau.apps.InThePoche.debug D/WebView.onCM: Uncaught TypeError: annotation must have an id for delete() @ 23: file:///android_asset/annotator.min.js

Existing annotations cannot be deleted.

2020-07-27 11:44:42.352 26160-26936/fr.gaulupeau.apps.InThePoche.debug E/MainService: run() exception during task execution
    org.greenrobot.greendao.DaoException: Entity has no key
        at org.greenrobot.greendao.AbstractDao.getKeyVerified(AbstractDao.java:932)
        at org.greenrobot.greendao.AbstractDao.deleteInTxInternal(AbstractDao.java:679)
        at org.greenrobot.greendao.AbstractDao.deleteInTx(AbstractDao.java:715)
        at fr.gaulupeau.apps.Poche.service.workers.OperationsWorker.deleteAnnotation(OperationsWorker.java:492)
        at fr.gaulupeau.apps.Poche.service.OperationsHelper.lambda$deleteAnnotation$3(OperationsHelper.java:88)
        at fr.gaulupeau.apps.Poche.service.-$$Lambda$OperationsHelper$XJNNl-8Ttm8FoeMGJXDn3HxgZKM.run(Unknown Source:4)
        at fr.gaulupeau.apps.Poche.service.TaskService.run(TaskService.java:158)
        at fr.gaulupeau.apps.Poche.service.TaskService.lambda$gjfracnqY8x0_-mrxsx0oqjQmgk(Unknown Source:0)
        at fr.gaulupeau.apps.Poche.service.-$$Lambda$TaskService$gjfracnqY8x0_-mrxsx0oqjQmgk.run(Unknown Source:2)
        at java.lang.Thread.run(Thread.java:764)

I wonder when I broke that - I'm quite sure I tested all the basic functions when I implemented it.

Environment details

  • wallabag app version: master or somewhere near
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant