Fix annotations #1028
Merged
Fix annotations #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strubbl
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
I can confirm the deletion function is fixed now.
Directly after adding an annotation it was not possible to touch the edit button. Now it is possible.
i reviewed the code and it looks good to me.
In general, after touching an annotated text to get the annotation popup, the time from seeing the annotation popup incl. the edit/delete buttons to the disappearing of the edit/delete buttons is very short. Can we increase the time before the edit/delete buttons disappear? Or can we always show them?
This should go into a separate PR as i am merging this fix now.
Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out annotations got broken when I switched to async
TaskService: adding an annotation is supposed to be a synchronous operation. That is fixed with introduction ofFuturesupport inTaskService/ServiceHelper(may be useful for other stuff in the future).Annotation deletion seems to have been broken from the very beginning. I don't know how I missed that.
Fixes #1026.