Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndexOutOfBoundsException in ManageArticleTagsActivity #1027

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

di72nn
Copy link
Member

@di72nn di72nn commented Jul 27, 2020

...when there are less than 50 tags in total.

A crash from google console:

java.lang.IndexOutOfBoundsException:
  at java.util.ArrayList.subListRangeCheck (ArrayList.java:1016)
  at java.util.ArrayList.subList (ArrayList.java:1008)
  at fr.gaulupeau.apps.Poche.ui.ManageArticleTagsActivity.filterTagList (ManageArticleTagsActivity.java:460)
  at fr.gaulupeau.apps.Poche.ui.ManageArticleTagsActivity.updateSuggestedTagList (ManageArticleTagsActivity.java:309)
  at fr.gaulupeau.apps.Poche.ui.ManageArticleTagsActivity.textChanged (ManageArticleTagsActivity.java:305)
  at fr.gaulupeau.apps.Poche.ui.ManageArticleTagsActivity.access$000 (ManageArticleTagsActivity.java:51)
  at fr.gaulupeau.apps.Poche.ui.ManageArticleTagsActivity$1.afterTextChanged (ManageArticleTagsActivity.java:118)
  at android.widget.TextView.sendAfterTextChanged (TextView.java:10973)
  at android.widget.TextView.setText (TextView.java:6376)
  at android.widget.TextView.setText (TextView.java:6170)
  at android.widget.EditText.setText (EditText.java:146)
  at android.widget.TextView.setText (TextView.java:6127)
  at fr.gaulupeau.apps.Poche.ui.ManageArticleTagsActivity.setEditText (ManageArticleTagsActivity.java:429)
  at fr.gaulupeau.apps.Poche.ui.ManageArticleTagsActivity.onCreate (ManageArticleTagsActivity.java:148)
  at android.app.Activity.performCreate (Activity.java:7326)
  at android.app.Activity.performCreate (Activity.java:7317)
  at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1271)
  at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3072)

Shame on me.

...when there are less than 50 tags in total.
@tcitworld tcitworld merged commit 9089fba into master Jul 27, 2020
@tcitworld tcitworld deleted the fix_IndexOutOfBoundsException branch July 27, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants