Update target sdk #1071
Merged
Update target sdk #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translations are handled by Weblate
As a preparation for targeting Android 11
tcitworld
approved these changes
Oct 5, 2020
Strubbl
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read through Android 10 changes and it seems that targeting it should not break things. I also checked 8 & 9 and didn't find anything we haven't already addressed.
The lint-related commits are not required for the target SDK change, but they make lint report less horrendous (and checking the report is important for the change).
I tested this PR on Android 11 emulator.
It also works fine with #1068 included.
Fixes #1024, fixes #644.