Lazy loading of article content and full-text search
#874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strubbl
requested changes
Nov 19, 2019
app/src/main/java/fr/gaulupeau/apps/Poche/data/OperationsHelper.java
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/gaulupeau/apps/Poche/data/WallabagDbOpenHelper.java
Show resolved
Hide resolved
app/src/main/java/fr/gaulupeau/apps/Poche/data/WallabagDbOpenHelper.java
Show resolved
Hide resolved
app/src/main/java/fr/gaulupeau/apps/Poche/data/WallabagDbOpenHelper.java
Show resolved
Hide resolved
app/src/main/java/fr/gaulupeau/apps/Poche/data/WallabagDbOpenHelper.java
Outdated
Show resolved
Hide resolved
This was referenced Nov 19, 2019
di72nn
force-pushed
the
lazy_content_and_fts
branch
from
5ca1245 to
1263f2a
Compare
Strubbl
approved these changes
Nov 20, 2019
tcitworld
approved these changes
Jan 3, 2020
di72nn
force-pushed
the
lazy_content_and_fts
branch
from
1263f2a to
69a7aef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
contentload lazily. To achieve that I had to movecontentto a separate table - I don't know how to make a field load lazily with Greendao otherwise. This probably fixes IllegalStateException: Couldn't read row 0, col 0 from CursorWindow (in GreenDAO's list method) #413. Also improves performance of lists.Currently
titleandcontentare separately indexed by FTS (can be used in queries liketitle:linux, see the previous link).This PR implements external content FTS tables, so there's no data duplication as in #871. Updating of FTS table is implemented using triggers. A lot of triggers *sigh*.
The features are not so closely related, but seeing how FTS adds constraints, I decided to implement both in one PR.