Fix credentials "Autofill" function #988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #986.
How it worked before:
The problem was that sometimes (not sure what it depends on) the list in the third step doesn't contain the newly created client. And if there is no other client (with a different name) to fall back to, the autofill fails.
To work around it I added a 1-second pause before the third step. I think this should do it.
There was also a 3+ years old TODO to use the creation result in step 2 (it contains credentials for the created client). I implemented this part, so it should be a little more optimized now.
So here's how it works now: