Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling socials links into a config file #2199

Merged
merged 3 commits into from
Jul 21, 2016

Conversation

Simounet
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation no
Fixed tickets
License MIT

Hi there,
I'm not sure would merge this but at the time I did these changes, social links URLs were wrong and I thought it might be a good idea to mutualize these informations.

@tcitworld
Copy link
Member

Thanks. The new Chrome extension for v2 is at https://chrome.google.com/webstore/detail/wallabagit/peehlcgckcnclnjlndmoddifcicdnabm (it was changed inside wallabag a few weeks ago)

@tcitworld tcitworld added this to the 2.0.6 milestone Jul 20, 2016
@tcitworld
Copy link
Member

Can you run php-cs-fixer on your changes too please ?

@Simounet
Copy link
Member Author

Done.

@j0k3r
Copy link
Member

j0k3r commented Jul 21, 2016

Looking good to me, thanks ! 👍

@j0k3r j0k3r merged commit 8c7d7c0 into wallabag:master Jul 21, 2016
@Simounet Simounet deleted the facto/social-links branch July 21, 2016 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants