Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade FOSUserBundle to 2.1 #5782

Merged
merged 4 commits into from
Aug 15, 2022
Merged

Conversation

yguedidi
Copy link
Contributor

@yguedidi yguedidi commented May 5, 2022

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Documentation no
Translation no
CHANGELOG.md no
License MIT

This reduce by 376 the number of direct deprecations, from 1492 to 1116.
Better reviewed commit by commit

@Kdecherf Kdecherf requested review from j0k3r, Kdecherf and nicosomb May 12, 2022 21:04
@yguedidi yguedidi marked this pull request as draft May 21, 2022 21:50
@j0k3r j0k3r changed the base branch from master to 2.6.0 May 23, 2022 05:59
@j0k3r j0k3r added this to the 2.6.0 milestone May 23, 2022
@yguedidi yguedidi force-pushed the upgrade-fosuserbundle branch from 5b41b8f to e9ce0ba Compare June 5, 2022 11:13
@yguedidi yguedidi marked this pull request as ready for review June 5, 2022 11:13
@yguedidi yguedidi mentioned this pull request Jun 5, 2022
2 tasks
@yguedidi yguedidi force-pushed the upgrade-fosuserbundle branch from e9ce0ba to 9a9ff7d Compare June 5, 2022 21:37
@yguedidi yguedidi marked this pull request as draft June 5, 2022 21:38
@yguedidi yguedidi force-pushed the upgrade-fosuserbundle branch from 9a9ff7d to 44daf53 Compare August 8, 2022 13:48
@yguedidi yguedidi marked this pull request as ready for review August 8, 2022 13:53
@yguedidi
Copy link
Contributor Author

yguedidi commented Aug 8, 2022

@Kdecherf @j0k3r @nicosomb ready for a review!

@yguedidi yguedidi mentioned this pull request Aug 8, 2022
5 tasks
@yguedidi yguedidi force-pushed the upgrade-fosuserbundle branch from 44daf53 to 34eebdb Compare August 15, 2022 15:23
@yguedidi
Copy link
Contributor Author

yguedidi commented Aug 15, 2022

@Kdecherf @j0k3r @nicosomb updated on latest 2.6.0.

would be great to have this merged so that I can advance on Symfony 4 upgrade 🙂

draft roadmap for the upgrade:

some small PRs may appear in between as a discover things

@Kdecherf Kdecherf merged commit 3c815f7 into wallabag:2.6.0 Aug 15, 2022
@yguedidi yguedidi deleted the upgrade-fosuserbundle branch August 15, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants