Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag deletion from tags list #5861

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Add tag deletion from tags list #5861

merged 4 commits into from
Jun 29, 2022

Conversation

nicosomb
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation no
CHANGELOG.md yes/no
License MIT

Fixed #2952

Need help for design (@Simounet maybe?)

@nicosomb nicosomb added this to the 2.6.0 milestone Jun 14, 2022
@nicosomb nicosomb requested review from j0k3r and Kdecherf June 14, 2022 14:46
Copy link
Member

@Kdecherf Kdecherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a screenshot and a prompt for asking the user to confirm the deletion?

@Simounet
Copy link
Member

Simounet commented Jun 15, 2022

Here is the screen. I used a JS confirm() but this is not a good practice so if I'm motivated enough, I'll do another PR to replace the confirm()'s by a better handler like a11ydialog.
tag-delete-action.

@nicosomb nicosomb requested a review from Kdecherf June 15, 2022 09:18
@nicosomb
Copy link
Member Author

Thank you @Simounet

@yguedidi
Copy link
Contributor

@nicosomb according to the milestone set, shouldn't this PR target the 2.6.0 branch instead of master? or change the milestone of course! :)

@j0k3r j0k3r changed the base branch from master to 2.6.0 June 15, 2022 14:15
@j0k3r j0k3r force-pushed the feat-2952-delete-tag branch from 3079d72 to e00e081 Compare June 15, 2022 14:16
@j0k3r j0k3r force-pushed the feat-2952-delete-tag branch from e00e081 to e55cb63 Compare June 15, 2022 14:18
@j0k3r j0k3r changed the title Added tag deletion from tags list Add tag deletion from tags list Jun 29, 2022
@j0k3r j0k3r merged commit 1c66344 into 2.6.0 Jun 29, 2022
@j0k3r j0k3r deleted the feat-2952-delete-tag branch June 29, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove tag from tag/list
5 participants