Replace kernel.root_dir by kernel.project_dir #6809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yguedidi
commented
Aug 7, 2023
| @@ -2,16 +2,16 @@ const path = require('path'); | |||
| const webpack = require('webpack'); | |||
| const StyleLintPlugin = require('stylelint-webpack-plugin'); | |||
|
|
|||
| const rootDir = path.resolve(__dirname, '../../../'); | |||
| const projectDir = path.resolve(__dirname, '../../../'); | |||
There was a problem hiding this comment.
this rename is not needed as it's in the JS, but I did it for consistency with back-end naming
yguedidi
commented
Aug 7, 2023
| @@ -6,7 +6,7 @@ parameters: | |||
| database_name: ${DATABASE_NAME:-symfony} | |||
| database_user: ${DATABASE_USER:-root} | |||
| database_password: ${DATABASE_PASSWORD:-~} | |||
| database_path: '${DATABASE_PATH:-"%kernel.root_dir%/data/db/wallabag.sqlite"}' | |||
| database_path: '${DATABASE_PATH:-"%kernel.project_dir%/data/db/wallabag.sqlite"}' | |||
There was a problem hiding this comment.
looks like the previous default value was broken as root_dir is the directory where the kernel is, so app/, while data/ is at the root of the project, not inside app/
yguedidi
force-pushed
the
replace-kernel.root_dir-by-kernel.project_dir
branch
from
3c0a0ca to
50e9930
Compare
yguedidi
force-pushed
the
replace-kernel.root_dir-by-kernel.project_dir
branch
from
50e9930 to
cc33fcb
Compare
nicosomb
approved these changes
Aug 10, 2023
|
Here the equivalent on the docker repo wallabag/docker#361 |
Kdecherf
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from https://github.com/symfony/symfony/blob/4.4/UPGRADE-5.0.md#httpkernel