Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse buffers for label comparison #1

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Reuse buffers for label comparison #1

merged 3 commits into from
Apr 28, 2023

Conversation

fpetkovski
Copy link

Optimize heap comparison function.

@fpetkovski
Reuse buffers for label comparison
85067c3 
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
@fpetkovski fpetkovski mentioned this pull request Apr 27, 2023
Merged
2 tasks
GiedriusS
GiedriusS reviewed Apr 27, 2023
View reviewed changes
pkg/store/proxy_heap.go Outdated Show resolved Hide resolved
@fpetkovski
Use len instead of cap
d2c6333 
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
@fpetkovski
Use len instead of cap
b8977d0 
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
wallee94
wallee94 approved these changes Apr 28, 2023
View reviewed changes
Copy link
Owner

@wallee94 wallee94 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to benchmark and analyze the performance issues. I understand the difference, and I think it is much better now. Everything looks good to me 👍

@wallee94 wallee94 merged commit 380b1e4 into wallee94:change-proxy-response-heap-less-func Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS left review comments

@wallee94 wallee94 wallee94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpetkovski @GiedriusS @wallee94