Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Format CSV files #246

Closed
gdevenyi opened this issue Sep 23, 2024 · 5 comments
Closed

Feature Request: Format CSV files #246

gdevenyi opened this issue Sep 23, 2024 · 5 comments

Comments

@gdevenyi
Copy link

lesspipe offers formatting of CSV files, by breaking on comma and using the column command line program to provide easily readable output.

I would like to request moar provide similar formatting functionality.

Colouring the columns (rainbowcsv) is another way which would greatly improve readability of CSVs.

Thanks.

@walles
Copy link
Owner

walles commented Sep 23, 2024

I'm not so keen on neither formatting nor calling external tools, but highlighting I think should be there.

I filed a request at alecthomas/chroma#1004 since there seems not to be any CSV highlighter in the library I use.

@walles
Copy link
Owner

walles commented Sep 23, 2024

Setting to help-wanted since they say:

Please note that lexers are contributed by the community. Your best option is to contribute this yourself.

The fastest way to get working CSV highlighting might be to implement it for Chroma.

@walles
Copy link
Owner

walles commented Sep 29, 2024

Made a highlighting PR: alecthomas/chroma#1005

walles added a commit that referenced this issue Nov 1, 2024
With this change, JSON files will now be implicitly reformatted before
being displayed.

This can be disabled with the `--no-reformat` switch.

Inspired by these two requests:
- #247
- #246
@walles
Copy link
Owner

walles commented Nov 10, 2024

I have given this some thought and I think reformatting CSV files would be too tricky.

There are lots of CSV files out there not conforming to the RFC, so parsing a CSV file will always involve some kind of guesswork.

Guessing wrong and then misformatting would be bad.

So I'll not do this.

Coloring I think should be fine, because getting the coloring wrong is much less bad than getting the formatting wrong. So I think the recoloring PR I made for upstream is still fine, even if that one is bound to get the coloring wrong sometimes. I'll make sure coloring gets included once the upstream PR goes in.

@walles walles closed this as completed Nov 10, 2024
@gdevenyi
Copy link
Author

Colouring will make things much more readable, I'm happy with this 👍 thanks.

walles added a commit that referenced this issue Nov 16, 2024
By bumping Chroma to a version that has that.

Improves on #246.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants