-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Revert this template" info line should include profile and region arguments #120
Comments
Indeed. Great suggestion. The region information is actually quite paramount when running template. We already already store it for past template executions (i.e. logs). We use it to prevent from reverting a template in a different region that it was run. So we will append a For the profile, I am not so sure as for now. Issues reverting with a stored past profile are:
Those cases above would cause unnecessary and extra revert errors due to profile issue, whereas without specifying a profile |
I gave awless the profile name (and credentials/permission) at the time of invocation, and I would think it is fair for awless to assume that the same profile name (and credentials/permission) would be used for a rollback.
If I go mucking around with my profile names, credentials, policies, roles, groups or whatever, that is my fault and not awless. All I'm looking for awless to do is tell me what I gave it. Actually, it would also be nice if In my case, I have 49 long-running AWS profiles which are kept up to date with a token vending machine. The profile names stay the same, the roles/policies also stay the same, and I rotate out credentials as I need to. If I did need to revert something, it would sure be easier to locate. |
The revert help line is mainly used when you are in the flow so we can always append the profile and region flag, as it will help in the copy/paste. (My points above where mainly about storing the information - profile - permanently). Re-thinking about it, you are right that storing and adding the profile make sense and could help without much disruption. |
Done. You can get it from master. It will be included in the next release: 0.1.2 |
@jeremymturner we try to focus Cheers. |
If I specify a separate AWS Profile and/or AWS Region on the command line, the "Revert this template" line should automatically include those same parameters.
How it looks with v0.1.1:
$ awless -p ProfileName -r us-east-1 create instance count=1 image=ami-xxxxxxxx name=xxxxxxxx subnet=subnet-xxxxxx type=t2.micro [info] Revert this template with `awless revert xxxxxxxxxxxxxxxxxxxxxxxxxxxxx`
How I think it should look:
$ awless -p ProfileName -r us-east-1 create instance count=1 image=ami-xxxxxxxx name=xxxxxxxx subnet=subnet-xxxxxx type=t2.micro [info] Revert this template with `awless revert xxxxxxxxxxxxxxxxxxxxxxxxxxxxx -p ProfileName -r us-east-1`
The text was updated successfully, but these errors were encountered: