This repository has been archived by the owner on Mar 20, 2021. It is now read-only.
Handle non-fully qualified ajax calls #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve per url.relative rules
| @@ -59,6 +60,11 @@ module.exports = exports = function($, exec, ajaxCache) { | |||
| jsonp = true; | |||
| } | |||
|
|
|||
| // Relative URL, handle as appropriate | |||
There was a problem hiding this comment.
will this work correctly if it is a protocol relative url? http://tools.ietf.org/html/rfc3986#section-4.2
There was a problem hiding this comment.
It did not. Added a test and made the code more generic to handle this case. Good catch.
|
+1 |
|
lgtm |
kpdecker
added a commit
that referenced
this pull request
Mar 17, 2014
Handle non-fully qualified ajax calls
|
Released in 0.3.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve per url.relative rules