Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token transfers in tx details page #13

Closed
saimeunt opened this issue Jun 20, 2024 · 5 comments
Closed

Token transfers in tx details page #13

saimeunt opened this issue Jun 20, 2024 · 5 comments
Assignees
Labels
good first issue Good for newcomers OD Hack

Comments

@saimeunt
Copy link
Collaborator

Token transfers in tx details page

⚠️ Reading contributors guidelines to get assigned is MANDATORY!

Read contributors guidelines

User stories

  • As a user, I want to see the list of ERC20 tokens transfers that occurred in a transaction.
    For each item in the list, I can click on from / to / token addresses and get redirected to the corresponding account detail page.

Validation

It should look like the Etherscan token transfers list, eg. https://optimistic.etherscan.io/tx/0x3b680d4727227d6afb35ddf620c3b16e33877f3cc06ec1151a6c45bd167b9f30
For the time being, we will only track ERC20 transfers and display only the token amount and raw addresses from / to / token, you should not compute the amount in $ or try to map the the token address to a list of known tokens.
You do not need to compute the net transfers either.

Image

Implementation

You will need to leverage the logs emitted in the transaction and create your list of token transfers from the Transfer events.
You should continue the work already done on the basic tx detail page and reuse the description list component.

Resources

@saimeunt saimeunt added this to OP Scan Jun 20, 2024
@saimeunt saimeunt converted this from a draft issue Jun 20, 2024
@saimeunt saimeunt added good first issue Good for newcomers OD Hack labels Jun 20, 2024
@melnikga
Copy link
Contributor

Hi, can I take this?

@addegbenga
Copy link

will like to work on this here is my OD hack profile

@Dprof-in-tech
Copy link
Contributor

Dprof-in-tech commented Jun 20, 2024

Hello @saimeunt
I am Isaac, a full stack JavaScript developer with a proven record of successful contributions to starknet and of hack projects.

I would love to be assigned to this issue and would be sure to deliver a solution in 2 business days and if there are any blockers I would tender a notice beforehand.

My solution would be to follow the requirements and provide a token transfer page with minimal features as requested.

Take inspiration from the provided link while making sure the user experience is as good as the user interface and deliver in a timely manner.

Below is my Onlydust contribution profile

https://app.onlydust.com/u/Dprof-in-tech

@saimeunt
Copy link
Collaborator Author

Assigning to @melnikga as he is a returning contributor.
@Dprof-in-tech Thanks for your interest I will assign to you another similar issue.

@Dprof-in-tech
Copy link
Contributor

Dprof-in-tech commented Jun 20, 2024

Assigning to @melnikga as he is a returning contributor.

@Dprof-in-tech Thanks for your interest I will assign to you another similar issue.

Okay ser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers OD Hack
Projects
Status: Done
Development

No branches or pull requests

4 participants