Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removal of state management hacks, readme update #815

Merged
merged 13 commits into from
Nov 7, 2024
Merged

removal of state management hacks, readme update #815

merged 13 commits into from
Nov 7, 2024

Conversation

severinstampler
Copy link
Contributor

@severinstampler severinstampler commented Nov 4, 2024 •
edited
Loading

Description

  • Removal of issuer state management hacks
  • Update of README according to recent changes.

@severinstampler severinstampler changed the title 98 refactor openid4vc library 2 update readme for recent changes Nov 4, 2024
philpotisk
philpotisk requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@philpotisk philpotisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The new stateless APIs should be documented
  • The implemented specification incl. the version should be referenced

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@severinstampler severinstampler changed the title update readme for recent changes removal of state management hacks, readme update Nov 7, 2024
@philpotisk philpotisk requested a review from waltkb November 7, 2024 10:14
waltkb
waltkb approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@waltkb waltkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like some great improvements!

@philpotisk philpotisk merged commit 5c2b501 into main Nov 7, 2024
4 checks passed
@philpotisk philpotisk deleted the 98-refactor-openid4vc-library-2 branch November 7, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltkb waltkb waltkb approved these changes

@philpotisk philpotisk philpotisk approved these changes

@taminobaumann taminobaumann Awaiting requested review from taminobaumann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@severinstampler @philpotisk @waltkb