Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wal-619 Delete AWS key #819

Merged
merged 26 commits into from
Nov 22, 2024
Merged

wal-619 Delete AWS key #819

merged 26 commits into from
Nov 22, 2024

Conversation

SuperBatata
Copy link
Contributor

@SuperBatata SuperBatata commented Nov 10, 2024 •
edited
Loading

Description

Implement AWS delete key function

TODO :

  • refactor the endpoint to have a flag in order to choose if we remove the reference of the key or the key and its reference
  • or maybe create another enpoint to delete remote key (actual key from kms)

Type of Change

  • bug fix - change which fixes an issue
  • new feature - change which adds functionality

Checklist

  • code cleanup and self-review
  • unit + e2e test coverage
  • documentation updated accordingly

Breaking

  • -

@SuperBatata SuperBatata marked this pull request as ready for review November 15, 2024 09:03
@philpotisk philpotisk requested review from philpotisk and removed request for cpatsonakis November 15, 2024 09:24
@SuperBatata SuperBatata self-assigned this Nov 21, 2024
philpotisk
philpotisk previously approved these changes Nov 21, 2024
View reviewed changes
@SuperBatata SuperBatata requested review from mikeplotean and removed request for mikeplotean November 21, 2024 16:07
@SuperBatata SuperBatata dismissed stale reviews from mikeplotean and philpotisk via 7924fde November 22, 2024 11:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@philpotisk philpotisk merged commit 013d3ac into main Nov 22, 2024
4 checks passed
@philpotisk philpotisk deleted the wal-619-delete-aws-key branch November 22, 2024 14:32
@philpotisk philpotisk mentioned this pull request Nov 22, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeplotean mikeplotean mikeplotean approved these changes

@philpotisk philpotisk philpotisk left review comments

Assignees

@SuperBatata SuperBatata

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperBatata @philpotisk @mikeplotean