Fix path processing logic in addToMdocRequest #880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently by requesting an iso/mdoc from the Wallet resulting a wallet succesfully sending a mdoc. The received mdoc on Verifier side however does not contain any attributes requested in the presentation request. This is due to the processing logic in the
addToMdocRequest
function (here)Currently, this line splits the namespace concatenated with the requested attribute using a
.
as the delimiter. However, for namespaces that already contain a.
(such as those in mdl), this causes the claim and the namespace to be incorrectly split and then added to the MDocRequestBuilder. In case oforg.iso.18013.5.1
, onlyorg
is set to be the namespace. This is leading to incorrect behavior, as the full path isn't being processed as expected.The following is one of the
presentation_definition
, which requestsfirst_name
in the mdl. The mdl containsgiven_name
,family_name
and other attributes:Type of Change
Checklist