fix: Reorganize the way values are passed #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpanzella
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
danielpanzella
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
danielpanzella
changed the title
danielpanzella
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
…ORE to use the new values
danielpanzella
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
danielpanzella
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
danielpanzella
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
danielpanzella
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
danielpanzella
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
danielpanzella
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
danielpanzella
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
danielpanzella
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
danielpanzella
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
danielpanzella
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
danielpanzella
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
zacharyblasczyk
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving around some values to simplify the interface between our terraform and the chart, and to make more clear what values are needed by the charts that were previously being passed as global envs.