Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Additional bigtable and pubsub fixes #268

Merged
merged 13 commits into from
Dec 2, 2024
Merged

fix: Additional bigtable and pubsub fixes #268

merged 13 commits into from
Dec 2, 2024

Conversation

danielpanzella
Copy link
Contributor

@danielpanzella danielpanzella commented Nov 26, 2024 •
edited
Loading

  • Allow bigtablev3 to be enabled via boolean global.bigtable.enableV3
  • Allow bigtablev2 to be enabled via boolean global.bigtable.enableV2
  • Added GORILLA_METADATA_CACHE env var to gorilla services

@danielpanzella danielpanzella marked this pull request as ready for review December 2, 2024 18:16
zacharyblasczyk
zacharyblasczyk reviewed Dec 2, 2024
View reviewed changes
charts/operator-wandb/charts/filestream/templates/_helpers.tpl Outdated
{{- end }}
{{- end }}
{{- $fileStreamStore := "" -}}
{{- if .Values.global.bigtable.v3.enabled -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be embedded?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be possible to enable v2 without v3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is possible to enable V2 without V3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, looks like this needs to be changed then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me fix this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@danielpanzella danielpanzella merged commit 4103c08 into main Dec 2, 2024
2 checks passed
@danielpanzella danielpanzella deleted the danielpanzella/fixes-for-bigtable-and-pubsub branch December 2, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annirudh annirudh annirudh left review comments

@zacharyblasczyk zacharyblasczyk zacharyblasczyk approved these changes

@jsbroks jsbroks Awaiting requested review from jsbroks jsbroks is a code owner

@vanpelt vanpelt Awaiting requested review from vanpelt vanpelt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielpanzella @annirudh @zacharyblasczyk