feat: Backend config, mysql connection string, hpa #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
danielpanzella
approved these changes
Jan 21, 2025
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
changed the title
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
commented
Jan 22, 2025
| GORILLA_HISTORY_STORE: | ||
| value: 'http://{{ .Release.Name }}-parquet:8087/_goRPC_,{{ include "wandb.mysql" . | trim }}' | ||
| GORILLA_FILE_STORE: | ||
| value: '{{ (include "wandb.bucket" . | fromYaml).url }}' | ||
| GORILLA_STORAGE_BUCKET: | ||
| value: '{{ (include "wandb.bucket" . | fromYaml).url }}' | ||
| A_KAFKA_CLIENT_PASSWORD: |
There was a problem hiding this comment.
This solves an ordering issue.
danielpanzella
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are planning to remove the conditional for the backend on
{{- if .Values.global.createGCPLoadBalancerBackend }}just need time to validate.We can also make the spec conditional for the backend config in the future.
ref INFRA-269