fix(weave): global df in op fails during op saving #2755
+38
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=889688e634c5039eb3408724dcef078f4161678c |
| except Exception as e: | ||
| print(f"Error getting code deps for {fn}: {e}") | ||
| return { | ||
| "import_code": [], |
There was a problem hiding this comment.
While you are in the area, would you fix the docstring for the return value of this method.
| @@ -4,6 +4,7 @@ | |||
| import platform | |||
| import sys | |||
|
|
|||
| import pandas as pd | |||
There was a problem hiding this comment.
I think you will need to add an explicit dependency in noxfile.py for this?
| df.loc[df.index[0], "a"] = a | ||
| return prev_val | ||
|
|
||
| res = my_op("d") |
There was a problem hiding this comment.
Got something odd going on here with type annotations - my_op says it takes and returns ints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slack thread
Testing
How was this PR tested?