Polish (#19)

- Add label to manifest task panes. - Publish instructions. - Marketplace snapshot.
wandyezj · Apr 8, 2024 · 4357ee4 · 4357ee4
1 parent b0ae8c2
commit 4357ee4
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 13 deletions.
diff --git a/docs/excel-taskpane-1366-768.png b/docs/excel-taskpane-1366-768.png
diff --git a/docs/publish.md b/docs/publish.md
@@ -0,0 +1,3 @@
+# Publish
+
+[Publish Dashboard](https://partner.microsoft.com/en-us/dashboard/marketplace-offers/overview)
diff --git a/manifests/local.xml b/manifests/local.xml
@@ -65,6 +65,7 @@
                   <Action xsi:type="ShowTaskpane">
                     <TaskpaneId>ButtonId1</TaskpaneId>
                     <SourceLocation resid="TaskpaneEdit.Url" />
+                    <Title resid="TaskpaneEdit.Title" />
                   </Action>
                 </Control>
                 <Control xsi:type="Button" id="TaskpaneButtonRun">
@@ -81,10 +82,11 @@
                   <Action xsi:type="ShowTaskpane">
                     <TaskpaneId>ButtonIdRun</TaskpaneId>
                     <SourceLocation resid="TaskpaneRun.Url" />
+                    <Title resid="TaskpaneRun.Title" />
                   </Action>
                 </Control>
               </Group>
-              <Label resid="TabExtension.TabLabel" />
+              <Label resid="TabBuild.TabLabel" />
             </CustomTab>
           </ExtensionPoint>
         </DesktopFormFactor>
@@ -116,6 +118,7 @@
                   <Action xsi:type="ShowTaskpane">
                     <TaskpaneId>ButtonId1</TaskpaneId>
                     <SourceLocation resid="TaskpaneEdit.Url" />
+                    <Title resid="TaskpaneEdit.Title" />
                   </Action>
                 </Control>
                 <Control xsi:type="Button" id="TaskpaneButtonRun">
@@ -132,10 +135,11 @@
                   <Action xsi:type="ShowTaskpane">
                     <TaskpaneId>ButtonIdRun</TaskpaneId>
                     <SourceLocation resid="TaskpaneRun.Url" />
+                    <Title resid="TaskpaneRun.Title" />
                   </Action>
                 </Control>
               </Group>
-              <Label resid="TabExtension.TabLabel" />
+              <Label resid="TabBuild.TabLabel" />
             </CustomTab>
           </ExtensionPoint>
         </DesktopFormFactor>
@@ -166,6 +170,7 @@
                   <Action xsi:type="ShowTaskpane">
                     <TaskpaneId>ButtonId1</TaskpaneId>
                     <SourceLocation resid="TaskpaneEdit.Url" />
+                    <Title resid="TaskpaneEdit.Title" />
                   </Action>
                 </Control>
                 <Control xsi:type="Button" id="TaskpaneButtonRun">
@@ -182,10 +187,11 @@
                   <Action xsi:type="ShowTaskpane">
                     <TaskpaneId>ButtonIdRun</TaskpaneId>
                     <SourceLocation resid="TaskpaneRun.Url" />
+                    <Title resid="TaskpaneRun.Title" />
                   </Action>
                 </Control>
               </Group>
-              <Label resid="TabExtension.TabLabel" />
+              <Label resid="TabBuild.TabLabel" />
             </CustomTab>
           </ExtensionPoint>
         </DesktopFormFactor>
@@ -210,10 +216,12 @@
         <bt:Url id="TaskpaneRun.Url" DefaultValue="https://localhost:3000/run.html" />
       </bt:Urls>
       <bt:ShortStrings>
-        <bt:String id="TabExtension.TabLabel" DefaultValue="(local) Build" />
+        <bt:String id="TabBuild.TabLabel" DefaultValue="(local) Build" />
         <bt:String id="CommandsGroup.Label" DefaultValue="(local) Extension" />
         <bt:String id="TaskpaneButtonEdit.Label" DefaultValue="Edit" />
         <bt:String id="TaskpaneButtonRun.Label" DefaultValue="Run" />
+        <bt:String id="TaskpaneEdit.Title" DefaultValue="Edit" />
+        <bt:String id="TaskpaneRun.Title" DefaultValue="Run" />
       </bt:ShortStrings>
       <bt:LongStrings>
         <bt:String id="TaskpaneButtonEdit.Tooltip" DefaultValue="Edit Snip" />

diff --git a/manifests/production.xml b/manifests/production.xml
@@ -65,6 +65,7 @@
                   <Action xsi:type="ShowTaskpane">
                     <TaskpaneId>ButtonId1</TaskpaneId>
                     <SourceLocation resid="TaskpaneEdit.Url" />
+                    <Title resid="TaskpaneEdit.Title" />
                   </Action>
                 </Control>
                 <Control xsi:type="Button" id="TaskpaneButtonRun">
@@ -81,10 +82,11 @@
                   <Action xsi:type="ShowTaskpane">
                     <TaskpaneId>ButtonIdRun</TaskpaneId>
                     <SourceLocation resid="TaskpaneRun.Url" />
+                    <Title resid="TaskpaneRun.Title" />
                   </Action>
                 </Control>
               </Group>
-              <Label resid="TabExtension.TabLabel" />
+              <Label resid="TabBuild.TabLabel" />
             </CustomTab>
           </ExtensionPoint>
         </DesktopFormFactor>
@@ -116,6 +118,7 @@
                   <Action xsi:type="ShowTaskpane">
                     <TaskpaneId>ButtonId1</TaskpaneId>
                     <SourceLocation resid="TaskpaneEdit.Url" />
+                    <Title resid="TaskpaneEdit.Title" />
                   </Action>
                 </Control>
                 <Control xsi:type="Button" id="TaskpaneButtonRun">
@@ -132,10 +135,11 @@
                   <Action xsi:type="ShowTaskpane">
                     <TaskpaneId>ButtonIdRun</TaskpaneId>
                     <SourceLocation resid="TaskpaneRun.Url" />
+                    <Title resid="TaskpaneRun.Title" />
                   </Action>
                 </Control>
               </Group>
-              <Label resid="TabExtension.TabLabel" />
+              <Label resid="TabBuild.TabLabel" />
             </CustomTab>
           </ExtensionPoint>
         </DesktopFormFactor>
@@ -166,6 +170,7 @@
                   <Action xsi:type="ShowTaskpane">
                     <TaskpaneId>ButtonId1</TaskpaneId>
                     <SourceLocation resid="TaskpaneEdit.Url" />
+                    <Title resid="TaskpaneEdit.Title" />
                   </Action>
                 </Control>
                 <Control xsi:type="Button" id="TaskpaneButtonRun">
@@ -182,10 +187,11 @@
                   <Action xsi:type="ShowTaskpane">
                     <TaskpaneId>ButtonIdRun</TaskpaneId>
                     <SourceLocation resid="TaskpaneRun.Url" />
+                    <Title resid="TaskpaneRun.Title" />
                   </Action>
                 </Control>
               </Group>
-              <Label resid="TabExtension.TabLabel" />
+              <Label resid="TabBuild.TabLabel" />
             </CustomTab>
           </ExtensionPoint>
         </DesktopFormFactor>
@@ -210,10 +216,12 @@
         <bt:Url id="TaskpaneRun.Url" DefaultValue="https://wandyezj.github.io/build-add-in/run.html" />
       </bt:Urls>
       <bt:ShortStrings>
-        <bt:String id="TabExtension.TabLabel" DefaultValue="Build" />
+        <bt:String id="TabBuild.TabLabel" DefaultValue="Build" />
         <bt:String id="CommandsGroup.Label" DefaultValue="Extension" />
         <bt:String id="TaskpaneButtonEdit.Label" DefaultValue="Edit" />
         <bt:String id="TaskpaneButtonRun.Label" DefaultValue="Run" />
+        <bt:String id="TaskpaneEdit.Title" DefaultValue="Edit" />
+        <bt:String id="TaskpaneRun.Title" DefaultValue="Run" />
       </bt:ShortStrings>
       <bt:LongStrings>
         <bt:String id="TaskpaneButtonEdit.Tooltip" DefaultValue="Edit Snip" />

diff --git a/manifests/template.xml b/manifests/template.xml
@@ -51,7 +51,7 @@
                   <bt:Image size="32" resid="Icon.32x32" />
                   <bt:Image size="80" resid="Icon.80x80" />
                 </Icon>
-                <Control xsi:type="Button" id="TaskpaneButton">
+                <Control xsi:type="Button" id="TaskpaneButtonEdit">
                   <Label resid="TaskpaneButtonEdit.Label" />
                   <Supertip>
                     <Title resid="TaskpaneButtonEdit.Label" />
@@ -65,6 +65,7 @@
                   <Action xsi:type="ShowTaskpane">
                     <TaskpaneId>ButtonId1</TaskpaneId>
                     <SourceLocation resid="TaskpaneEdit.Url" />
+                    <Title resid="TaskpaneEdit.Title" />
                   </Action>
                 </Control>
                 <Control xsi:type="Button" id="TaskpaneButtonRun">
@@ -81,10 +82,11 @@
                   <Action xsi:type="ShowTaskpane">
                     <TaskpaneId>ButtonIdRun</TaskpaneId>
                     <SourceLocation resid="TaskpaneRun.Url" />
+                    <Title resid="TaskpaneRun.Title" />
                   </Action>
                 </Control>
               </Group>
-              <Label resid="TabExtension.TabLabel" />
+              <Label resid="TabBuild.TabLabel" />
             </CustomTab>
           </ExtensionPoint>
         </DesktopFormFactor>
@@ -112,10 +114,12 @@
         <bt:Url id="TaskpaneRun.Url" DefaultValue="https://localhost:3000/run.html" />
       </bt:Urls>
       <bt:ShortStrings>
-        <bt:String id="TabExtension.TabLabel" DefaultValue="(local) Build" />
+        <bt:String id="TabBuild.TabLabel" DefaultValue="(local) Build" />
         <bt:String id="CommandsGroup.Label" DefaultValue="(local) Extension" />
         <bt:String id="TaskpaneButtonEdit.Label" DefaultValue="Edit" />
         <bt:String id="TaskpaneButtonRun.Label" DefaultValue="Run" />
+        <bt:String id="TaskpaneEdit.Title" DefaultValue="Edit" />
+        <bt:String id="TaskpaneRun.Title" DefaultValue="Run" />
       </bt:ShortStrings>
       <bt:LongStrings>
         <bt:String id="TaskpaneButtonEdit.Tooltip" DefaultValue="Edit Snip" />

diff --git a/src/core/defaultSnip.tsx b/src/core/defaultSnip.tsx
@@ -1,7 +1,7 @@
 import { PrunedSnip } from "./Snip";
 
 export const defaultSnip: PrunedSnip = {
-    name: "Default Snip",
+    name: "New Snip",
     files: {
         typescript: {
             language: "typescript",
@@ -21,7 +21,8 @@ Office.onReady(({host, platform})=> {
     elementHost.innerText = \`\${host}\`;
     elementHost.style.color = getHostColor(host);
 
-    document.getElementById('platform').innerText = \`\${platform}\`;
+    const elementPlatform = document.getElementById('platform');
+    elementPlatform.innerText = \`\${platform}\`;
 });
 
 /**
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		# Publish

		[Publish Dashboard](https://partner.microsoft.com/en-us/dashboard/marketplace-offers/overview)