mklibffmpeg: update comments for msvc shared+static build

wang-bin · Dec 3, 2023 · b9c5493 · b9c5493
1 parent 51e08c3
commit b9c5493
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/tools/mklibffmpeg.sh b/tools/mklibffmpeg.sh
@@ -1,11 +1,11 @@
-# A script to create libffmpeg single shared library. Author: 'wbsecg1 at gmail.com' 2019-2022. MIT license
+# A script to create libffmpeg single shared library. Author: 'wbsecg1 at gmail.com' 2019-2023. MIT license
 BUILD_DIR=$1
 INSTALL_DIR=$2
 THIS_DIR="$(cd "$(dirname ${BASH_SOURCE[0]})";pwd -P)"
 
 cd "$BUILD_DIR"
 
-# TODO: win dllimport LNK4217 fix (lib.exe tt.obj /export:func /def, static lib?). also make it possible to build both static and shared lib for ffmpeg modules
+# msvc shared+static in one build requires https://github.com/wang-bin/avbuild/commit/65cb54ec6c2c19852cad78d9863aff3c17934c73
 if [ -f libavutil/libavutil.dll.a ]; then
 # avpriv_ are declared as av_export_avcodec/avutil, mingw link error, undefined '_imp__avpriv_mpa_freq_tab' etc.. this also results in ffmpeg can not be built both static and shared for windows
   echo "mingw ld does not support linking a single ffmpeg dll"