refactor: simplify sample data saved object id prefix logic #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanglam
reviewed
Sep 12, 2023
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl
force-pushed
the
simplify-sample-data-functions
branch
from
b7e891b
to
3bda7bd
Compare
rename appendPrefix to addPrefix Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
wanglam
approved these changes
Sep 12, 2023
wanglam
merged commit b14f835
into
wanglam:feat-import-sample-data-saved-objects-to-workspace
20 of 47 checks passed
wanglam
added a commit
that referenced
this pull request
Sep 14, 2023
…ct#118) * feat: import sample data saved objects to workspace Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: update typo saveObject to savedObject Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: separate getWorkspaceAndDataSourceIntegratedSavedObjects to getDataSourceIntegratedSavedObjects and getWorkspaceIntegratedSavedObjects Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: update to cloneDeep Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: simplify sample data saved object id prefix logic (#1) * refactor: simplify sample data saved object id prefix logic Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * fix: align the prefix order of sample data install and uninstall rename appendPrefix to addPrefix Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
wanglam
added a commit
that referenced
this pull request
Sep 15, 2023
…ct#118) * feat: import sample data saved objects to workspace Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: update typo saveObject to savedObject Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: separate getWorkspaceAndDataSourceIntegratedSavedObjects to getDataSourceIntegratedSavedObjects and getWorkspaceIntegratedSavedObjects Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: update to cloneDeep Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: simplify sample data saved object id prefix logic (#1) * refactor: simplify sample data saved object id prefix logic Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * fix: align the prefix order of sample data install and uninstall rename appendPrefix to addPrefix Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
wanglam
pushed a commit
that referenced
this pull request
Oct 7, 2023
* refactor: simplify sample data saved object id prefix logic Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * fix: align the prefix order of sample data install and uninstall rename appendPrefix to addPrefix Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
wanglam
added a commit
that referenced
this pull request
Oct 16, 2023
…ect#210) * feat: import sample data saved objects to workspace Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: simplify sample data saved object id prefix logic (#1) * refactor: simplify sample data saved object id prefix logic Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * fix: align the prefix order of sample data install and uninstall rename appendPrefix to addPrefix Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * refactor: assigned copied saved objects to new variables Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
wanglam
added a commit
that referenced
this pull request
Feb 22, 2024
…ect#210) * feat: import sample data saved objects to workspace Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: simplify sample data saved object id prefix logic (#1) * refactor: simplify sample data saved object id prefix logic Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * fix: align the prefix order of sample data install and uninstall rename appendPrefix to addPrefix Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * refactor: assigned copied saved objects to new variables Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit simplifies code for prefixing dashboard and saved object IDs in the sample data service
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr