Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master find duplicate records #15

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

wangtaohz
Copy link
Owner

Why are the changes needed?

(For example: The Arctic Flink dataStream API has already supported this configuration: 'scan.startup.mode', but it is not available with Flink SQL. We should expose this configuration to users when they are using Flink SQL.)

Brief change log

(For example:)

  • Add the 'scan.startup.mode' configuration to the ArcticScanContext in the flink modules
  • The Flink 1.12 and 1.14 versions are affected.
  • Add the documentation in the flink chapter

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Merging #15 (e68229b) into master (333434d) will decrease coverage by 2.35%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##             master      #15      +/-   ##
============================================
- Coverage     51.01%   48.67%   -2.35%     
+ Complexity     3765      582    -3183     
============================================
  Files           467       46     -421     
  Lines         25334     4368   -20966     
  Branches       2578      508    -2070     
============================================
- Hits          12924     2126   -10798     
+ Misses        11249     2009    -9240     
+ Partials       1161      233     -928     
Flag Coverage Δ
core ?
trino 48.67% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 422 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants