Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2007 #18

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Fix 2007 #18

wants to merge 11 commits into from

Conversation

wangtaohz
Copy link
Owner

Why are the changes needed?

Close #xxx.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Attention: 638 lines in your changes are missing coverage. Please review.

Comparison is base (835ff61) 50.83% compared to head (daeb270) 50.89%.
Report is 11 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #18      +/-   ##
============================================
+ Coverage     50.83%   50.89%   +0.05%     
- Complexity     3853     3924      +71     
============================================
  Files           476      492      +16     
  Lines         25698    26063     +365     
  Branches       2657     2693      +36     
============================================
+ Hits          13064    13264     +200     
- Misses        11474    11622     +148     
- Partials       1160     1177      +17     
Flag Coverage Δ
core 51.33% <45.04%> (+0.05%) ⬆️
trino 48.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...com/netease/arctic/optimizer/common/Optimizer.java 91.66% <ø> (ø)
...etease/arctic/server/DefaultOptimizingService.java 22.15% <ø> (ø)
...ease/arctic/server/catalog/IcebergCatalogImpl.java 73.33% <100.00%> (+27.17%) ⬆️
...tic/server/catalog/InternalIcebergCatalogImpl.java 89.28% <100.00%> (+0.39%) ⬆️
...arctic/server/catalog/MixedIcebergCatalogImpl.java 73.68% <100.00%> (+1.46%) ⬆️
...m/netease/arctic/server/catalog/ServerCatalog.java 100.00% <ø> (ø)
...tease/arctic/server/dashboard/DashboardServer.java 66.84% <100.00%> (+1.05%) ⬆️
...va/com/netease/arctic/server/manager/ExecUtil.java 0.00% <ø> (ø)
...etease/arctic/server/manager/SpiPluginManager.java 88.88% <100.00%> (+2.52%) ⬆️
...ease/arctic/server/optimizing/OptimizingQueue.java 73.81% <100.00%> (+0.14%) ⬆️
... and 58 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants