Separate engine modules / Fix wazero engine for TinyGo 0.35.0 #62
Conversation
pkedy
force-pushed
the
modules
branch
4 times, most recently
from
72918df to
1639549
Compare
Handling `sys.ExitError` returned by `_start` in wazero engine.
|
@madflojo You might want to check out this PR. |
| t.Errorf("Unexpected instance, have %v, expected %v", have, expected) | ||
| } | ||
| } | ||
| // import ( |
There was a problem hiding this comment.
Rather than commenting, maybe we should just delete this? Can always just grab from a previous tag if we ever need it again.
There was a problem hiding this comment.
I may very well do that in a future PR. I want to learn more about the state of wasmer-go and wasmtime-go.
| @@ -0,0 +1,14 @@ | |||
| module github.com/wapc/wapc-go/engines/wazero | |||
There was a problem hiding this comment.
One annoying thing I've found about multi module repos is that things like go tests and Golangci-lint don't automatically pickup all of the modules.
They require some magic tricks to properly catch things: https://github.com/tarmac-project/hord/blob/main/.github/workflows/lint.yml
There was a problem hiding this comment.
Surprising. Thanks for the heads up! Will investigate in a future PR.
|
@pkedy thanks for addressing this and keeping this project up and alive! |
|
@pkedy, can we cut a release of the engine module/s with this change? Without a specific release for those modules, the dependencies look like this: In case you've not had to create releases for sub-modules it's as simple as creating a tag with the module path, some examples: https://github.com/tarmac-project/hord/tags |
_initializeas a start function to support TinyGo 0.35.0 and the-buildmode=c-sharedflag.