Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP extension PECL swoole #33

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

@navarr
Copy link
Member

navarr commented Aug 9, 2024

@bap14 I see you approved this. Just want to double check that you've considered it against the reason you brought in OpenSwoole and that this'll be fine.

If you're on board with that, feel free to merge it!

@bap14
Copy link
Member

bap14 commented Aug 10, 2024

@navarr I didn't really have a particular reason to use openswoole vs swoole. I have no issues swapping it from openswoole to swoole. I did read up on the controversy around swoole and openswoole, and the supposed security issue, and feel it's been settled. I approved it after doing some reading up on that.

@navarr navarr merged commit 3f0b369 into wardenenv:main Aug 10, 2024
@lfluvisotto
Copy link
Contributor Author

@navarr, @bap14, as swoole is being used by Adobe Commerce, GraphQL Application Server, also I had to opportunity to use https://github.com/swoole/library, https://wiki.swoole.com/en/#/coroutine/coroutine?id=functions, coroutine > batch for an specific task of custom xml feed and processed faster rather than not using it, swoole is a great PHP extension for event-driven, asynchronous, non-blocking I/O model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants