-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating dockerfiles and entrypoint files according to latest system requirements of adobe commerce (magento open source) on-premises #34
Conversation
19eecd1
to
a81468b
Compare
php/cli/Dockerfile
Outdated
@@ -3,6 +3,7 @@ FROM quay.io/centos/centos:stream9 | |||
ARG PHP_VERSION | |||
ARG PHP_EXTENSIONS="bcmath cli common gd gmp intl json mbstring \ | |||
mcrypt sodium mysqlnd pgsql opcache pdo pdo_pgsql pecl-msgpack pecl-amqp pecl-redis pecl-imagick pecl-zip pecl-openswoole process soap xml xmlrpc" | |||
ARG COMPOSER_VERSION=2.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lfluvisotto Rather than locking us into version 2.7, I think it would be better if we use a more generic tag like latest
or simply the major version number 2
. Right now the "latest" tag and the "2" tag in Docker Hub refer to the same image hash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bap14, good catch, it went unnoticed by me, changed, please, check again.
a81468b
to
7d91c05
Compare
.gitignore
Outdated
@@ -0,0 +1,3 @@ | |||
/.sync |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not be committed. These ignores are specific to your computer and should be ignored via a global ignore
https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navarr interesting approach, file .gitignore removed from PR.
Should we apply the same approach in https://github.com/wardenenv/warden/blob/main/.gitignore ?
php/cli/Dockerfile
Outdated
COPY --from=composer:2 /usr/bin/composer /usr/bin/composer2 | ||
COPY --from=composer:2.2 /usr/bin/composer /usr/bin/composer2lts | ||
COPY --from=composer:${COMPOSER_VERSION} /usr/bin/composer /usr/bin/composer2 | ||
COPY --from=composer:lts /usr/bin/composer /usr/bin/composer2lts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see a future where lts is not 2 and everything breaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navarr reverted as it was.
0bfded8
to
0f072db
Compare
87e5f03
to
36ca781
Compare
@navarr , @bap14 , explanation about if conditional in php-fpm/context/docker-entrypoint First if Condition
This checks if COMPOSER_VERSION matches the pattern 1, 1.x, or 1.x.x (where x is one or more digits). Second elif Condition
This checks if COMPOSER_VERSION matches the pattern 2.2 or 2.2.x (where x is one or more digits). Third elif Condition
This checks if COMPOSER_VERSION matches the pattern 2, 2.x, or 2.x.x (where x is one or more digits). else Condition
If none of the above conditions are met, this else block will execute. |
…requirements of adobe commerce (magento open source) on-premises
36ca781
to
726211d
Compare
@navarr
https://experienceleague.adobe.com/en/docs/commerce-operations/installation-guide/system-requirements
node lts
https://github.com/magento/magento-cloud-docker/blob/5177d6580c4d61cb6c7d5fab14d39748d68d1f65/images/php/8.3-cli/Dockerfile#L35