-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore the only root .git directory #496
Conversation
I temporary use:
inside |
I faced with pure performance on one of my projects when ignored vsc. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@navarr, what do you think about porting this change to https://github.com/swiftotter/den? |
@ihor-sviziev Why have the git repositories in the container instead of on the host machine? |
@navarr, as I described in the original message, is the use case when you're having a single module in a few Magento 2 projects. Usually, to simplify development, we install the module via Right now, mutagen sync excludes all the git repositories from the sync, so it means inside the container, we do have a .git directory, but on the host machine, we don't, so we can't commit and push from the host machine. I think the people who upvoted my change do the same flow as I am. PS: I have a workaround for my case - #496 (comment), but would like to make it available for everyone. If it causes any issues - I'm ok to have a fix just for me. |
@navarr what do you think about porting this change to den? |
@ihor-sviziev I think this is likely a good and useful change. Can you open a PR against Den? |
While working with m2 projects, it's quite a frequent case when you have a separate git repository per extension, so while developing something you're installing a module from a branch, do your changes directly in vendor/<vendor_name>/<module_name> and then do commits directly from this. Such flow helps significantly reduce time on installing each new version via composer.
The issue with Warden in such configuration is that ALL .git folders are ignored in the mutagen config. As a result - on Mac OS, you can't see the diff, commit changes, etc. (the .git directory is entirely missing in the module folder)
My PR changes this behavior by ignoring the only root directory git repo.