Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional (opt-in) support for Mailpit #779

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

bap14
Copy link
Member

@bap14 bap14 commented Jun 25, 2024

Adds ability to easily switch to Mailpit, a maintained successor to Mailhog.

@bap14
Copy link
Member Author

bap14 commented Jun 25, 2024

@navarr This goes for this discussion: https://github.com/orgs/wardenenv/discussions/780

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tags in this file don't use the "array of strings" format because the redirect wasn't working unless I used the object style notation.

@bap14
Copy link
Member Author

bap14 commented Jul 23, 2024

@navarr This is ready for your review.

@navarr navarr added this pull request to the merge queue Aug 5, 2024
Merged via the queue into wardenenv:main with commit 60f3fdd Aug 5, 2024
@@ -0,0 +1,27 @@
services:
mailpit:
container_name: mailhog
Copy link
Contributor

@ihor-sviziev ihor-sviziev Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the container name is mailhog?
Just During upgrade, it caused a conflict
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For backwards compatibility so you can still reference "mailhog" but it's really just mailpit. This can easily be removed and whatever breaks will need to be upgraded.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The simple solution would be: warden svc down --remove-orphans && warden svc up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I did like that and it worked. But I got confused that container is named mailhog, while we don't have such service and domain. So I would prefer removing this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants